cmd-build-with-buildah: add --strict
#4324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the logic for this actually lives directly in `build-rootfs`, so just pass it through to that.
Member
Author
|
See also: coreos/fedora-coreos-config#3760 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a --strict flag to the cmd-build-with-buildah script. The implementation correctly parses the new flag and passes it as a build argument (STRICT_MODE=1) to the underlying buildah command. The changes are straightforward and well-implemented. I've pointed out a minor typo in the help text for an existing option that was modified in this PR.
Noticed by Gemini.
Member
Author
|
Fixed typo. CI went past the pylint check and the rest of the pipeline won't test this. Let's get it in to unblock coreos/fedora-coreos-config#3756. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the logic for this actually lives directly in
build-rootfs, so just pass it through to that.